Re: XForms: [PATCH] Double clicking doesn't work in file selectors

From: David Paigen (paigen@heathen.com)
Date: Thu Dec 19 2002 - 09:30:59 EST

  • Next message: Jeff Pierce: "Re: XForms: [PATCH] Double clicking doesn't work in file selectors"

    # To subscribers of the xforms list from David Paigen <paigen@heathen.com> :

    Mike wrote:
    > I have noticed that double clicking on a file/directory in the file
    > selector doesn't navigate to the file/directory, in 1.0. This has also been
    > reported on the XFMail listserv. The attached patch seems to fix the
    > problem, is this acceptable for integration into the main xforms source?

    And I thought it was just me. You can still doubleclick, but you
    must do it much faster. And maybe only after you try it a few times.
    However, I have a trackball, and my cursor does not move at all when
    I click.

    The symptoms seem clear, but I don't understand why your patch works.
    Are there MotionNotify events being generated when the mouse does not
    move? I am not an expert on X internals, but is there some threshold
    of movement (other than 1) to generate MotionNotifys?

    For that matter, what level are doubleclicks interpreted on? X? Xlib?
    Xt? XForms? Application? Somewhere else?

    -David Paigen
    paigen@heathen.com

    > --- fselect.c.orig Thu Dec 19 01:18:08 2002
    > +++ fselect.c Thu Dec 19 01:18:13 2002
    > @@ -319,7 +319,7 @@
    > {
    > int dir;
    > char seltext[FL_PATH_MAX];
    > - static int lastline = -1, clicked;
    > + static int lastline = -1, clicked = 0;
    > int dblclick, thisline;
    > FD_fselect *lfs = ob->form->fdui;
    > const XEvent *xev = fl_last_event();
    > @@ -340,7 +340,7 @@
    >
    > lastline = thisline;
    >
    > - clicked = (clicked || xev->type == ButtonPress);
    > + clicked = (clicked || xev->type == ButtonPress || xev->type == MotionNotify
    > );
    >
    > /* cursor keys can cause a single line being repeatedly selected
    > causing a wrong dblclick detection */
    >

    _________________________________________________
    To unsubscribe, send the message "unsubscribe" to
    xforms-request@bob.usuhs.mil or see
    http://bob.usuhs.mil/mailserv/xforms.html
    XForms Home Page: http://world.std.com/~xforms
    List Archive: http://bob.usuhs.mil/mailserv/list-archives/



    This archive was generated by hypermail 2b29 : Thu Dec 19 2002 - 09:31:34 EST