[XForms] [PATCH]: squashing all remaining warnings

Jean-Marc Lasgouttes Jean-Marc.Lasgouttes at inria.fr
Thu Nov 20 08:49:48 EST 2003

>>>>> "Angus" == Angus Leeming <angus.leeming at btopenworld.com> writes:

Angus> To subscribers of the xforms list Attached is a patch to squash
Angus> all the remaining warnings when compiling with CFLAGS='-W -Wall
Angus> -Wno-unused-parameter'. All these warnings are 'comparison of
Angus> signed and unsigned'.

Angus> I have been pretty careful here and when unsure have erred on
Angus> the side of caution, casting the unsigned var to signed. Much
Angus> of the time though I have felt that going the other way was
Angus> fine (ie, casting the signed var to unsigned).

And did you find any real problem in the process?

Angus> I would value it if someone would take the time to verify that
Angus> I haven't fubar-ed here.

I took a quick look at the patch and it looks like checking each and
every of these is a long process. I won't have time to do it.

So if you are confident, just apply the patch. Otherwise, we'll have
to live with the warnings :)


More information about the Xforms mailing list