[PATCH] Re: [XForms] Getting rid of auto-generated files...

[Angus Leeming]

On Wednesday 26 November 2003 1:37 pm, Jean-Marc Lasgouttes wrote:
> Angus> Lines 2,3. The problems. It appears that fdesign must be run
> Angus> from the directory containing the .fd file.
>
> Jean-Marc> So we could maybe take a look at fixing fdesign, since we
> Jean-Marc> have control on it :)
>
> The following patch fixes fdesign -convert for me. My problem was that
> I have a "." in my homedir name (/afs/inria.fr/...). Does it help you?

If it works for you, then I expect that it will work for me. I'll try it out 
this evening.

> Could you re-read the patch to make sure I did not make a mistake? I
> think using filename instead of fname is the right thing to do here.
>
> With this patch applied, I get the following diff on a sample fd file.
> So the difference is:
>
> 1/ the LGPL notice is gone. Is this a big problem?

No. These are generated files. If we really, really want an LGPL notice, the 
place to put it is in the .fd file. In turn that means enabling fdesign to 
handle comments in its .fd files. Something for the future, maybe, but not 
something to worry about now.

> 2/ we have
> -#include "include/forms.h"
> +#include "forms.h"
> I think this will be solved by using -I$(top_srcdir}/lib/include in
> INCLUDES.

Sure.

> Note also that fdesign now adds
> +/** Header file generated with fdesign on Wed Nov 26 14:25:19 2003.**/
> but only to the header (not the .c file). We should probably remove
> this altogether, since it creates useless diffs.

Agreed.

> What do you think?

I think that I like it when you claim to be 'too busy to think' ;-)
Regards,
Angus