[XForms] JPEG/EXIF support?

Jean-Marc Lasgouttes Jean-Marc.Lasgouttes at inria.fr
Thu Nov 27 06:32:05 EST 2003


>>>>> "Angus" == Angus Leeming <angus.leeming at btopenworld.com> writes:

Angus> To subscribers of the xforms list
Angus> On Wednesday 26 November 2003 10:06 pm, Michal Szymanski wrote:
>> > Could you revert Clive's patch and try the one I appended in my
>> original > reply to his posting? This patch contains the jpeg and
>> gif enhancements > and I am more than happy to merge it into the
>> xforms sources.
>> 
>> I've applied your version of Clive's patch to my home CVS source
>> tree. The Changelog patch got rejected but both "image" patches
>> succeeded. And my application reading images can now read JPEG/EXIF
>> files taken from my digital camera.

Angus> Then I shall commit it. Many thanks to you both, Angus

tru64 cc does not think that this code is OK:

cc -std1 -DHAVE_CONFIG_H -I. -I../../xforms/image -I../lib -DMAKING_FORMS -I../lib -I../../xforms/lib -I/afs/rocq/home/preval/common/include -I/usr/local/include -g -c -MD ../../xforms/image/image_gif.c  -DPIC -o .libs/image_gif.lo
cc: Warning: ../../xforms/image/image_gif.c, line 672: The scalar variable "incode" is fetched but not initialized. (uninit1)
        flush_buffer(im, incode);
-------------------------^

Indeed, if I read process_lzw_code correctly, the variable incode is
not always initialized. Since I do not understand what it stands for,
I cannot propose a fix, but obviously this needs to be fixed in some
way.

JMarc



More information about the Xforms mailing list