# To subscribers of the xforms list from Angus Leeming <angus.leeming@btopenworld.com> :
On Sunday 04 May 2003 9:38 pm, Mike Heffner wrote:
> Resending so this doesn't get lost. I've also filed this as bug# 3455 at
> the new project page.
Good man. Note taht I am very busy for the next couple of weeks, so probably
won't have any time to spare for xforms.
> -----Fwd: <XFMail.20021219013025.mheffner@vt.edu>-----
> I have noticed that double clicking on a file/directory in the file
> selector doesn't navigate to the file/directory, in 1.0. This has also been
> reported on the XFMail listserv. The attached patch seems to fix the
> problem, is this acceptable for integration into the main xforms source?
- static int lastline = -1, clicked;
+ static int lastline = -1, clicked = 0;
FYI, I believe that static variables are automatically initialised to zero.
Not that the above hurts any ;-)
- clicked = (clicked || xev->type == ButtonPress);
+ clicked = (clicked || xev->type == ButtonPress || xev->type ==
MotionNotify
I fail to se why this is the right thing to do. Can you explain the rationale?
At a glance, this would make more sense:
- dblclick = (lastline == thisline && clicked &&
+ dblclick = (lastline == thisline &&
+ clicked && xev->type == ButtonPress &&
fl_time_passed(FL_FS_T) < ob->click_timeout * 0.001f);
But the logic of this function is too complicated to follow late on a Sunday
evening ;-)
Regards,
Angus
_________________________________________________
To unsubscribe, send the message "unsubscribe" to
xforms-request@bob.usuhs.mil or see
http://bob.usuhs.mil/mailserv/xforms.html
XForms Home Page: http://world.std.com/~xforms
List Archive: http://bob.usuhs.mil/mailserv/list-archives/
Development: http://savannah.nongnu.org/files/?group=xforms
This archive was generated by hypermail 2b29 : Sun May 04 2003 - 18:16:59 EDT