Re: Fwd: XForms: [PATCH] Double clicking doesn't work in file selectors

From: Mike Heffner (mheffner@vt.edu)
Date: Sun May 04 2003 - 23:24:22 EDT

  • Next message: Jean-Marc Lasgouttes: "Re: XForms: autoconf/automake patch"

    # To subscribers of the xforms list from Mike Heffner <mheffner@vt.edu> :

    On 04-May-2003 Angus Leeming wrote:
    |
    | - clicked = (clicked || xev->type == ButtonPress);
    | + clicked = (clicked || xev->type == ButtonPress || xev->type ==
    | MotionNotify
    |
    | I fail to se why this is the right thing to do. Can you explain the
    | rationale?

    It was simply from printing out what 'xev->type' was coming in as. ;-) I am
    really not sure why it is MotionNotify -- it might signify bugs somewhere
    else -- but this was a quick fix that seemed to solve the problem.

    |
    | At a glance, this would make more sense:

    I would have to take another look at the code, but it wasn't true as-is
    before, so I'm not sure if adding an additional conditional here would
    help.

    |
    | - dblclick = (lastline == thisline && clicked &&
    | + dblclick = (lastline == thisline &&
    | + clicked && xev->type == ButtonPress &&
    | fl_time_passed(FL_FS_T) < ob->click_timeout * 0.001f);
    |

    Mike 

    -- 
  Mike Heffner       <mheffner@[acm.]vt.edu>
                         <mikeh@FreeBSD.org>

    _________________________________________________
To unsubscribe, send the message "unsubscribe" to
xforms-request@bob.usuhs.mil   or see
http://bob.usuhs.mil/mailserv/xforms.html
XForms Home Page: http://world.std.com/~xforms
List Archive: http://bob.usuhs.mil/mailserv/list-archives/
Development: http://savannah.nongnu.org/files/?group=xforms

    This archive was generated by hypermail 2b29 : Sun May 04 2003 - 23:24:22 EDT