[XForms] JPEG/EXIF support?

Angus Leeming angus.leeming at btopenworld.com
Tue Nov 25 16:09:26 EST 2003


On Monday 24 November 2003 11:43 pm, Clive A Stubbings wrote:
> A long time ago I did a patch to improve some stuff in the image
> handling.. It got lost in the move to 1.0
>
> But I can read images off my camera so it may solve your problem too..
> Patch is at http://www.vjet.demon.co.uk/xforms/image.patch

Got it.

> It probably needs massaging to work on the latest CVS. It fixes a bug in
> flimage_dup() ,

I'm not going to apply this without some discussion. Feel free to explain the 
rationale.

> one in image rotate.

I don't see the need for this. See the comment immediately preceeding your 
patched code. In cvs at least.
    /*
     * Now coerce it into +/- 180.
     */

> and makes jpeg + gif reading better.

I've applied both these parts to my local tree, albeit with some re-factoring 
to get rid of the goto and some signed-unsigned comparson warnings. Could you 
check to see that all is still as you intended (attached). If you could cast 
your eye over the ChangeLog entry and maybe rename 'flush_buffer' to 
something that makes sense to you, that'd be great too...

Regards,
Angus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clive.diff
Type: text/x-diff
Size: 3888 bytes
Desc: not available
Url : attachments/20031125/dead5e72/attachment-0010.bin 


More information about the Xforms mailing list