[XForms] XForms text rendering bug patch

[Jean-Marc Lasgouttes]

>>>>> "Dmitry" == Dmitry Karasik <dmitry at karasik.eu.org> writes:

Dmitry> To subscribers of the xforms list Under certain condition,
Dmitry> input lines do not display any text. The bug, which is
Dmitry> basically comparison of a signed integer as a boolean, is
Dmitry> fixed by the following patch:

Hello,

Thanks for the patch. I think we are suffering from this bug in LyX
in some circumstances, but we never got to fix it.

Are you sure that your fix is the right one? I do not know this part
of code at all, but the comment before the function says:

/* Major text drawing routine
 * clip == 0:  no clipping
 * clip == 1:  do clipping here
 * clip == -1: clipping is done outside of this routine
 */

so testing for clip as a boolean means 'if there is some clipping
going on somewhere', which may be a reasonable test. Are you sure that
only the 'do clipping here' case should be handled?

We want to be extra careful about the side-effects.

JMarc