[XForms] XForms text rendering bug patch

Angus Leeming angus.leeming at btopenworld.com
Wed May 5 12:46:18 EDT 2004


On Wednesday 05 May 2004 5:30 pm, Jean-Marc Lasgouttes wrote:
> Angus> Actually, wouldn't this bug be fixed by changing this:
>
> Angus> 	/* Check whether visible */
> Angus> 	if (clip != 0 && (starty[i] + flx->fdesc) > y + h)
> continue;
>
> Angus> to this:
>
> Angus> 	/* Check whether visible */
> Angus> if (clip != 0 && starty[i] > y + h) continue;
>
> Angus> Ie, draw this line of text even if it extends beyond the
> widget Angus> and then rely on XSetClipRectangles to do its stuff.
>
> It seems reasonable. Do we have a way to check that it does what we
> think it does?

Here's the (correct) patch and a test case that works as expected with 
it and displays nothing without it.

Angus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: text.diff
Type: text/x-diff
Size: 651 bytes
Desc: not available
Url : attachments/20040505/e6cfca40/attachment-0020.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: input_test.C
Type: text/x-c++src
Size: 921 bytes
Desc: not available
Url : attachments/20040505/e6cfca40/attachment-0021.bin 


More information about the Xforms mailing list