[XForms] Patch: Context Sharing + fdesign (real thing)

[Jean-Marc Lasgouttes]

>>>>> "Angus" == Angus Leeming <angus.leeming at btopenworld.com> writes:

>> Do you think it would work correctly?

Angus> Yes. However, I don't think we should add HAVE_GLCANVAS_H to
Angus> *our* autoconf files. 

Did I say something like that? It would not make much sense, actually.

Angus> This 'nonsense' is for whatever configure-magic the *user* uses
Angus> to compile his code. All *we* need to do is to provide the
Angus> pre-processor handle. Why not be explicit and define
Angus> INCLUDE_GLCANVAS_H_FROM_CANVAS_H ? I think that being verbose
Angus> here is a good thing.

OK, you are probaly right, although the define should be
INCLUDE_GLCANVAS_H_FROM_FORMS_H or maybe the slightly shorter 
AUTOINCLUDE_GLCANVAS_H.

Angus> This is all separate to the 'glcanvas.h should be
Angus> self-contained' problem.
>>  Concerning this later problem, I am not sure we want to enforce
>> it. Asking people to include forms.h seems rather reasonable to me.

Angus> <whine> But it's inelegant! </whine>

Angus> Anyway, the #include <GL/glx.h> and the C++ guards are
Angus> definitely needed IMO. Agree?

Yes.

OK, it probably does not hurt to make it self contained, but I think
it encourages sloppiness, since glcanvas.h is such a tiny portion of
the forms api. I do not see anybody wanting to use _only_
glcanvas-related API in a program. I think people should include
headers for the API that they explicitly use.

JMarc