[XForms] [patch] API pseudo changes

Jean-Marc Lasgouttes Jean-Marc.Lasgouttes at inria.fr
Tue May 18 08:00:56 EDT 2004


>>>>> "Angus" == Angus Leeming <angus.leeming at btopenworld.com> writes:

Angus> To subscribers of the xforms list The attached patch partially
Angus> reverts the appearance of the API to that of XForms 0.89 patch
Angus> level 5. In all cases, this is just a case of using the typedef
Angus> rather than the raw type. In all cases, this results in a
Angus> clearer intent.

Angus> The patch seems completely uncontroversial to me. Any
Angus> objections, or should I just shove it in?

It looks like the right thing to do, but I do not understand why
things have been changed previously. There has to be a reason, don't
you think?

Angus> While I'm at it, several functions that were declared using
Angus> 'unsigned int' are now declared using 'unsigned'. Eg:

Angus> -Window fl_get_mouse(FL_Coord *, FL_Coord *, unsigned int *);
Angus> +Window fl_get_mouse(FL_Coord *, FL_Coord *, unsigned *);

Angus> Again, they're equivalent, but I fail to see why the change was
Angus> a good one. Shall I change them back?

I think so.

JMarc



More information about the Xforms mailing list