[XForms] Genuine API changes to forms.h, glcanvas.h since XForms 0.89

[Todd Denniston]

Angus Leeming wrote:
> 
> To subscribers of the xforms list
> 
> Jean-Marc, all,
> 
> I think that below are all the genuine API changes to forms.h since
> XForms 0.89. AFAICS, there is only one genuine regression and that it
> probably trivial. Nonetheless, I guess we should
> #define fl_set_error_logfp fl_set_err_logfp.
> 
Don't know don't care.

> I don't see any implications in passing 'unsigned long' to functions
> that used to receive 'unsigned' vars. Are there any implications when
> using shared objects?
> 
Probably not with gcc (int and long are 32 bits), might be with other
compilers.

> I don't see any implications at all to returning an 'int' from
> functions that were previously declared as 'void'.
> 
void means no return value, int means there is an integer return value.
if the user wants to ignore the return value, that is probably fine, I think
some compiler settings will warn on ignoreing return values.
However if the function is defined as an int it should ALWAYS exit by
returning an integer. I have not looked at the code for the function(s) you
are refering too, but as long as there is a reason (return value) for them to
be int all is good.

> I have no feeling whatsoever about the implications of functions
> previously receiving 'char *' that now receive 'char []'.
> 
I suppose they are equivilent but the 'char *' has always been more clear to
me and more common in the code I have recived. If you like the new way go with
it.

> Once these points have been nailed down, it'll be trivial to document
> these changes.
> 
> Angus
> 
<SNIP>
-- 
Todd Denniston
Crane Division, Naval Surface Warfare Center (NSWC Crane) 
Harnessing the Power of Technology for the Warfighter