[XForms] once more about popups

[laurent FOURNIER]

Dear Jean-Marc,

I have tried your patch in the initialization routine for popups 
(function fl_setpup_maxpup).
In my application the sequence is the following :
FL_OBJECT *obj = fl_add_menu(type, x, y, w, h, label);
fl_set_object_boxtype(obj, FL_UP_BOX);
fl_setpup_default_fontsize(CL_FONT_SIZE); /* this is an integer from 
config file, usually = 8 or 10 */
fl_setpup_default_fontstyle(FL_NORMAL_STYLE);

I made a new run this morning on LynxOS and got the following while 
calling fl_setup_default_fontsize() in the above sequence :
X Error of failed request: BadWindow (invalid Window parameter)
  Major opcode of failed request: 4 (X_DestroyWindow)
etc...
Then the program enters a deadlock while stacking calls to XSync() (but 
this is likely a problem with X11 itself on LynxOS) while calling 
close_pupwin() (xpopup.c line 430).
The error occurs because the field pup->win is not initialized to zero  
... and does not occur in my own patched version. One more argument 
towards memset() ! :-)
But I do not understand why this did not appear before...

Amicalement,
Laurent.